fix ptl_bugs in slu_models.py #7689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seonghun Noh <jzi040941@naver.com>
for more information, see https://pre-commit.ci
stevehuang52
requested changes
Oct 12, 2023
There was a problem hiding this comment.
Thanks for the fix~!
Could you please also change the trainer.strategy=ddp to trainer.strategy=ddp_find_unused_parameters_true in the yaml file? It was giving the following error when I ran with ddp:
RuntimeError: It looks like your LightningModule has parameters that were not used in producing the loss returned by training_step. If this is intentional, you must enable the detection of unused parameters in DDP, either by setting the string value `strategy='ddp_find_unused_parameters_true'` or by setting the flag in the strategy with `strategy=DDPStrategy(find_unused_parameters=True)`.
@jzi040941 did you experience the same issue?
I'll approve once this is resolved.
Signed-off-by: Seonghun <jzi040941@naver.com>
|
@stevehuang52 Yes, I had same issue with I updated the yaml file, thanks~ |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
* fix ptl_bugs in slu_models.py Signed-off-by: Seonghun Noh <jzi040941@naver.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change strategy to ddp_find_unused_parameters_true in slu example yaml Signed-off-by: Seonghun <jzi040941@naver.com> --------- Signed-off-by: Seonghun Noh <jzi040941@naver.com> Signed-off-by: Seonghun <jzi040941@naver.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
titu1994
pushed a commit
that referenced
this pull request
Oct 13, 2023
* fix ptl_bugs in slu_models.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change strategy to ddp_find_unused_parameters_true in slu example yaml --------- Signed-off-by: Seonghun Noh <jzi040941@naver.com> Signed-off-by: Seonghun <jzi040941@naver.com> Co-authored-by: Seonghun Noh <jzi040941@naver.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
yaoyu-33
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix ptl_bugs in slu_models.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change strategy to ddp_find_unused_parameters_true in slu example yaml --------- Signed-off-by: Seonghun Noh <jzi040941@naver.com> Signed-off-by: Seonghun <jzi040941@naver.com> Co-authored-by: Seonghun Noh <jzi040941@naver.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
* fix ptl_bugs in slu_models.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change strategy to ddp_find_unused_parameters_true in slu example yaml --------- Signed-off-by: Seonghun Noh <jzi040941@naver.com> Signed-off-by: Seonghun <jzi040941@naver.com> Co-authored-by: Seonghun Noh <jzi040941@naver.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* fix ptl_bugs in slu_models.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change strategy to ddp_find_unused_parameters_true in slu example yaml --------- Signed-off-by: Seonghun Noh <jzi040941@naver.com> Signed-off-by: Seonghun <jzi040941@naver.com> Co-authored-by: Seonghun Noh <jzi040941@naver.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
This PR added fixes for PTL2.0 related SLU bugs in r1.21.0: Val metrics logging, None dataloader issue
Collection:
ASR
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
@stevehuang52 @titu1994
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information